Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move ACL from inside DRP to outside DRPObject #318

Merged
merged 39 commits into from
Jan 15, 2025
Merged

feat: move ACL from inside DRP to outside DRPObject #318

merged 39 commits into from
Jan 15, 2025

Conversation

anhnd350309
Copy link
Contributor

@anhnd350309 anhnd350309 commented Jan 6, 2025 •
edited
Loading

Description

Move ACL from inside DRP to outside DRPObject

How

  • Add a new attribute: vertexType in Interface Vertex.Operation with two possible values: drp, acl.
  • Implement each method: computeACL, computeACLState, computeDRP, and computeDRPState again. Check if the vertex is from drp or acl to merge or apply the operation

TODO

  • update testcase again
  • new vertexType in Operation
  • Implement login again in DRPObject
  • delete some testcase AddWinsSetWithACL

Resolve #313

@anhnd350309 anhnd350309 changed the title feat: add acl to DRPobject Move ACL from inside DRP to outside DRPObject Jan 7, 2025
@anhnd350309 anhnd350309 marked this pull request as ready for review January 7, 2025 06:26
@anhnd350309 anhnd350309 changed the title Move ACL from inside DRP to outside DRPObject feat: move ACL from inside DRP to outside DRPObject Jan 7, 2025
trungnotchung
trungnotchung reviewed Jan 7, 2025
View reviewed changes
trungnotchung
trungnotchung reviewed Jan 8, 2025
View reviewed changes
d-roak
d-roak reviewed Jan 11, 2025
View reviewed changes
@anhnd350309 anhnd350309 requested a review from sfroment as a code owner January 12, 2025 04:22
@anhnd350309 anhnd350309 requested a review from winprn as a code owner January 13, 2025 03:12
@d-roak d-roak requested a review from magnified103 as a code owner January 15, 2025 21:08
@d-roak d-roak merged commit 21f9e3d into main Jan 15, 2025
12 checks passed
@d-roak d-roak deleted the feat/move-acl-to-outside branch January 24, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-roak d-roak d-roak left review comments

@JanLewDev JanLewDev JanLewDev left review comments

@trungnotchung trungnotchung trungnotchung left review comments

@hoangquocvietuet hoangquocvietuet hoangquocvietuet left review comments

@sfroment sfroment Awaiting requested review from sfroment sfroment is a code owner

@winprn winprn Awaiting requested review from winprn winprn is a code owner

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the ACL to DRPObject instead of keeping it inside DRP
5 participants
@anhnd350309 @d-roak @JanLewDev @trungnotchung @hoangquocvietuet